NotificationsYou must be signed in to change notification settings
Fork5.5k
Star12.8k

Fixes 3182#5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

blink1073 merged 1 commit intojupyter:masterfromwithrocks:3182-paste-different-images-in-text-cell

Jul 23, 2020

Merged

Fixes 3182#5598

blink1073 merged 1 commit intojupyter:masterfromwithrocks:3182-paste-different-images-in-text-cell

Jul 23, 2020

Conversation

Copy link

Contributor

withrocks commentedJul 10, 2020•
edited
Loading

Issue#3182 "Can't paste two images from clipboard in markdown cell"
happens when the user tries to paste a second image into a text
cell and the image gets the same attachment key as the previous one.

This patch fixes that issue by adding an index to each picture that's
pasted after the previous one. Example:

User pastes an image blob A. The text![image.png](attachment:image.png)
is added to the text cell and the blob is saved as attachmentimage.png
The user pastes a second image blob B. The same happens as with blob
A, except the key is nowimage-2.png rather thanimage.png

Special case:

If the user pastes the exact same blob A twice, it will not be added to
the attachments, but the textcell will get a second entry of
![image.png](attachment:image.png).

Fixes 3182

f033e1a

Issue 3182 "Can't paste two images from clipboard in markdown cell"happens when the user tries to paste a second image into a textcell and the image gets the same attachment key as the previous one.This patch fixes that issue by adding an index to each picture that'spasted after the previous one. Example:* User pastes an image blob A. The text `![image.png](attachment:image.png)`  is added to the text cell and the blob is saved as attachment `image.png`* The user pastes a second image blob B. The same happens as with blob  A, except the key is now `image-1.png` rather than `image.png`Special case:If the user pastes the exact same blob A twice, it will not be added tothe attachments, but the textcell will get a second entry of`![image.png](attachment:image.png)`.