- Notifications
You must be signed in to change notification settings - Fork5.5k
descriptive log for port unavailable and port-retries=0#5136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
kevin-bates left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change looks good - thank you.
While we're on this topic and this area of the code, I think a similar change should be made to theinfo message within the for loop. That is, don't issue the "trying another port" clause when retries are not desired.
kevin-bates commentedJan 4, 2020
Also please edit your initial comment above to include |
pallavibharadwaj commentedJan 5, 2020
Edited the comment, thank you. Is removing the |
kevin-bates commentedJan 5, 2020
I'm only suggesting the clause's removal when |
pallavibharadwaj commentedJan 6, 2020
@kevin-bates - I have added the changes you suggested, in the PR. I made a new commit instead of rebasing, in order to highlight my new changes. I will rebase the commits if needed after you approve it. Thank you. |
Uh oh!
There was an error while loading.Please reload this page.
kevin-bates left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM - thank you for you first contribution! 🎉
Zsailer left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
Uh oh!
There was an error while loading.Please reload this page.
when
--port-retries=0and the launch fails on the port, the error logERROR: the notebook server could not be started because no available port could be found.is not very appropriate.Fixes:#1914