Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

descriptive log for port unavailable and port-retries=0#5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Zsailer merged 2 commits intojupyter:masterfrompallavibharadwaj:issue_1914
Jan 7, 2020

Conversation

@pallavibharadwaj
Copy link
Contributor

@pallavibharadwajpallavibharadwaj commentedJan 4, 2020
edited
Loading

when--port-retries=0 and the launch fails on the port, the error logERROR: the notebook server could not be started because no available port could be found. is not very appropriate.Fixes:#1914

pajenterprisesllc reacted with thumbs down emojisibis and Zsailer reacted with rocket emoji
Copy link
Member

@kevin-bateskevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change looks good - thank you.

While we're on this topic and this area of the code, I think a similar change should be made to theinfo message within the for loop. That is, don't issue the "trying another port" clause when retries are not desired.

pajenterprisesllc reacted with thumbs up emoji
@kevin-bates
Copy link
Member

Also please edit your initial comment above to includeFixes: #1914 as the last line in the comment. This instructsgit to close that Issue upon the merge of this PR. Thanks.

pallavibharadwaj reacted with thumbs up emoji

@pallavibharadwaj
Copy link
ContributorAuthor

Edited the comment, thank you.

Is removing thetrying another port part of the log a good idea, since that would be consistent withPermission to listen on port 403 denied? Or would you suggest having this clause in both the cases?

@kevin-bates
Copy link
Member

I'm only suggesting the clause's removal whenself.port_retries == 0. When non-zero we should indicate other ports will be attempted, but not when retries are disabled. I believe the permission message is fine as-is - although I suppose one could argue that it too should include the 'trying another port` clause (only when retries are enabled). That said, you typically want to provide only the necessary information in security-related messaging, so perhaps leaving that one alone is probably best given it didn't include the clause in the first place.

@pallavibharadwaj
Copy link
ContributorAuthor

@kevin-bates - I have added the changes you suggested, in the PR. I made a new commit instead of rebasing, in order to highlight my new changes. I will rebase the commits if needed after you approve it. Thank you.

Copy link
Member

@kevin-bateskevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - thank you for you first contribution! 🎉

sibis reacted with thumbs up emojipallavibharadwaj reacted with hooray emoji
Copy link
Member

@ZsailerZsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

pallavibharadwaj reacted with hooray emoji
@ZsailerZsailer merged commitf354740 intojupyter:masterJan 7, 2020
@pallavibharadwajpallavibharadwaj deleted the issue_1914 branchJanuary 7, 2020 20:07
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 25, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ZsailerZsailerZsailer approved these changes

+1 more reviewer

@kevin-bateskevin-bateskevin-bates approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tries random ports, even if --port is given

3 participants

@pallavibharadwaj@kevin-bates@Zsailer

[8]ページ先頭

©2009-2025 Movatter.jp