- Notifications
You must be signed in to change notification settings - Fork5.5k
Implemented Split Cell for multicursor#4824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
blink1073 approved these changesJun 3, 2020
Contributor
blink1073 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the current split cell functionality and made it work for multicursor. The help message for split cell is also updated to imply multicursor splitting is possible.
This can be done by putting the cursor at multiple locations (Alt+Drag/Ctrl+Click) and pressing Ctrl+Shift+Minus. The result should be new cells split at each of the cursors.
Additionally, this PR now makes cell splitting handles selections, so if you select a piece of code/text, then hit Ctrl+Shift+Minus, it'll put the selected text in a new cell with the text before/after the text going into their own cells. It is able to handle a combination of cursors and selections.
I retained the functionality of removing newlines at the beginning and end of the created cells, so the original single cursor behavior remains the same.