Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

added--autoreload flag toNotebookApp#4795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
blink1073 merged 2 commits intojupyter:masterfromtelamonian:webapp-autoreload
May 23, 2020

Conversation

@telamonian
Copy link
Contributor

@telamoniantelamonian commentedJul 31, 2019
edited
Loading

When the--autoreload flag is passed, the webapp will watch for any changes to its Python source. On change, all changed packages will be reimported and the webapp will restart. Also works on Python source files in Jupyter server extensions. Implemented using the built inautoreload parameter in the constructor oftornado.web.Application, whichNotebookApp.web_app is a subclass of.

While I was working on aserver extension for Jupyterlab, I got pretty sick of having to kill and restart Jupyterlab every time I made changes to the Python source. This PR is an attempt to enable hot reloading for the sources ofnotebook and any extensions.

Though the autoreload behavior is currently a bit cumbersome (the Notebook server will reload completely from scratch, including (on Jupyterlab, at least) launching a new browser window with a new security token), I believe that it is useful as is. I also think that in the future it can definitely be improved, most obviously by recycling certain resources on reload, such as browser windows and security tokens.

SgtPooki, mlucool, jtpio, and oeway reacted with thumbs up emoji
Copy link
Contributor

@blink1073blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, thanks!

telamonian reacted with thumbs up emoji
@meeseeksmachine
Copy link

This pull request has been mentioned onJupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/reload-jupyter-serverextension/2200/3

@blink1073
Copy link
Contributor

@telamonian, do you mind rebasing this one?

@blink1073blink1073 added this to the6.1 milestoneMay 22, 2020
@telamonian
Copy link
ContributorAuthor

Can do

telamonianand others added2 commitsMay 22, 2020 19:12
When passed, the webapp will watch for any changes to its Python source. Onchange, all changed packages will be reimported and the webapp will restart.Also works on Python source files in Jupyter server extensions. Implementedusing the built in `autoreload` parameter in the constructor of`tornado.web.Application`.
@telamonian
Copy link
ContributorAuthor

telamonian commentedMay 22, 2020
edited
Loading

@blink1073 done!

@blink1073
Copy link
Contributor

Thanks!

@blink1073blink1073 merged commit01e298f intojupyter:masterMay 23, 2020
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 24, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@blink1073blink1073blink1073 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@telamonian@meeseeksmachine@blink1073

[8]ページ先頭

©2009-2025 Movatter.jp