Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Solve issue #3940: The dropdown submenu at notebook page is not keyboard accessible#4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@taohan16
Copy link
Contributor

@taohan16taohan16 commentedJun 27, 2019•
edited by takluyver
Loading

Add "dropdown-toggle" and "dropdown-submenu" classes to link element in html.

Addresses#3940

@takluyver
Copy link
Member

Are all the CSS & JS changes necessary for this as well, or did they just get mixed up with the HTML changes you mentioned? If they're necessary, can they have some comments to briefly explain what they are?

@taohan16
Copy link
ContributorAuthor

Are all the CSS & JS changes necessary for this as well, or did they just get mixed up with the HTML changes you mentioned? If they're necessary, can they have some comments to briefly explain what they are?

For issue#3940, the change in menubar.js is to prevent the dropdown menu is closed when clicking.
The changes in notebook.html are adding "dropdown-toggle" class and data-toggle attribute to tag of submenu because of the when keyboard focus on the dropdown submenu option is actually on the element.
The changes in acc_overwrites.less is to prevent the focus highlight border on submenu options lost after changing.

Copy link
Contributor

@blink1073blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@blink1073blink1073 added this to the6.1 milestoneJun 7, 2020
@blink1073blink1073 merged commita90121c intojupyter:masterJun 7, 2020
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 24, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@blink1073blink1073blink1073 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@taohan16@takluyver@blink1073
[8]ページ先頭
©2009-2025 Movatter.jp