NotificationsYou must be signed in to change notification settings
Fork5.5k
Star12.8k

add el & update css in output_area to match run button in input prompt from #3535#3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

rgbkrk merged 1 commit intojupyter:masterfrommpacer:consistent_prompt

Jun 14, 2018

Merged

add el & update css in output_area to match run button in input prompt from #3535#3687

rgbkrk merged 1 commit intojupyter:masterfrommpacer:consistent_prompt

Jun 14, 2018

Conversation

Copy link

Member

mpacer commentedJun 14, 2018

Without this change the output and Input areas become unaligned.

This still isn't an ideal fix, but it'll make a release possible without making the styling problematic.

This can be seen as a styling continuation of#3535.

add el & update css in output_area to match run button in In fromjup…

dd282f6

…yter#3535Without this change the output and Input areas become unaligned.This still isn't an ideal fix, but it'll make a release possible withoutmaking the styling problematic.

mpacer added this to the5.6 milestone

Jun 14, 2018

Copy link

MemberAuthor

mpacer commentedJun 14, 2018•
edited
Loading

@takluyver @minrk @gnestor I don't think this is super controversial (in comparison to 3535), can I get an expedited review so that I can proceed with making a release candidate for 5.6?

Copy link

MemberAuthor

Alternatively to a expedited review, if we do want to iterate on this PR a bunch, I'd like to suggest reverting#3535 to make a 5.6 release candidate possible, pushing it until 5.7 (or 5.6.1) when we can figure out a better way to handle the styling issues.