Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add kernel_info_timeout traitlet for slow kernel start/restart#3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
minrk merged 1 commit intojupyter:masterfrommpacer:reply_timeout
Jun 8, 2018

Conversation

@mpacer
Copy link
Member

@mpacermpacer commentedJun 6, 2018•
edited
Loading

This allows you to configure how long the notebook waits for a kernel give itskernel_info_reply.

I looked into adding a test, but I think that this would require a good bit of machinery to test properly. I can do that if we want to, but it looks like we're not testing the functionality of most other traitlets directly.

Note: this is not kernel specific… but I don't think we have any way to do kernel specific configuration for the handler as of today.

@mpacer
Copy link
MemberAuthor

Closes#1825.
@rgbkrk@Carrea@gnestor

@mpacermpacer changed the titleadd restart_reply_timeout configurable traitlet for slow kernelsWIP: add restart_reply_timeout configurable traitlet for slow kernelsJun 6, 2018
@mpacer
Copy link
MemberAuthor

mpacer commentedJun 6, 2018•
edited
Loading

I changed this to WIP because I want to make it also work for the initial startup timeout (as it is injupyter_console).

Now it does this.

@mpacermpacer changed the titleWIP: add restart_reply_timeout configurable traitlet for slow kernelsadd restart_reply_timeout configurable traitlet for slow kernelsJun 6, 2018
This affects both the MappingKernelManager and the ZMQChannelsHandler(by extension). This allows one setting to apply to both startup andrestarting.
"""
)

kernel_info_timeout=Float(60,config=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Excellent!

Copy link
Member

@rgbkrkrgbkrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super fan of this since we've been dealing with slower spark-backed kernels at Netflix.

@mpacermpacer changed the titleadd restart_reply_timeout configurable traitlet for slow kernelsadd kernel_info_timeout configurable traitlet for slow kernel startupJun 6, 2018
@mpacermpacer changed the titleadd kernel_info_timeout configurable traitlet for slow kernel startupadd kernel_info_timeout traitlet for slow kernel start/restartJun 6, 2018
@mpacer
Copy link
MemberAuthor

@Carreau@gnestor@takluyver@minrk Are there any issues with this going forward?

@minrk
Copy link
Member

Great!

@minrkminrk merged commit2c061a4 intojupyter:masterJun 8, 2018
@mpacermpacer added this to the5.6 milestoneJun 12, 2018
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 1, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@rgbkrkrgbkrkrgbkrk approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.6

Development

Successfully merging this pull request may close these issues.

3 participants

@mpacer@minrk@rgbkrk
[8]ページ先頭
©2009-2025 Movatter.jp