Jun 10, 2018 · Apr 21, 2018 · May 4, 2018 · May 4, 2018 · May 18, 2018 · Jun 1, 2018
diff --git a/notebook/tests/selenium/test_find_and_replace_apply_all.py b/notebook/tests/selenium/test_find_and_replace_apply_all.py
 importos
 importpytest


 deftest_find_and_replace_apply_all(notebook):
 """ test find and replace on all the cells """
 cell_0,cell_1,cell_2,cell_3="hello","hellohello","abc","ello"

 find_str="ello"# string to replace
 replace_str="foo"# string to replace to

 # set the contents of the cells
 notebook.add_cell(index=0,content=cell_0);
 notebook.add_cell(index=1,content=cell_1);
 notebook.add_cell(index=2,content=cell_2);
 notebook.add_cell(index=3,content=cell_3);

 # replace the strings
 notebook.find_and_replace(index=0,find_txt=find_str,replace_txt=replace_str,replace_all=True)

 # check content of the cells
 assertnotebook.get_cell_contents(0)==cell_0.replace(find_str,replace_str)
 assertnotebook.get_cell_contents(1)==cell_1.replace(find_str,replace_str)
 assertnotebook.get_cell_contents(2)==cell_2.replace(find_str,replace_str)
 assertnotebook.get_cell_contents(3)==cell_3.replace(find_str,replace_str)
diff --git a/notebook/tests/selenium/utils.py b/notebook/tests/selenium/utils.py
 import os

 import time
 from selenium.webdriver import ActionChains
 from selenium.webdriver.common.by import By
 from selenium.webdriver.common.keys import Keys
        self.to_command_mode()
        self.current_cell = cell

    def find_and_replace(self, index=0, find_txt='', replace_txt='', replace_all=False):
        self.focus_cell(index)
        esc(self.browser, 'F')
        time.sleep(1)    # TODO: find better way to fill the find and replace form
        self.browser.find_elements_by_css_selector("button.btn.btn-default.btn-sm")[2].click()
        JS = "document.getElementsByClassName('form-control input-sm')[0].setAttribute('value', '%s')"%find_txt
        self.browser.execute_script(JS)
        JS = "document.getElementsByClassName('form-control input-sm')[1].setAttribute('value', '%s')"%replace_txt
        self.browser.execute_script(JS)
        self.body.send_keys(Keys.TAB)
        self.body.send_keys(Keys.TAB)
        self.body.send_keys(Keys.ENTER)
        time.sleep(1)

    def convert_cell_type(self, index=0, cell_type="code"):
        # TODO add check to see if it is already present
        self.focus_cell(index)
    """Send key combination Ctrl+(k)"""
    ActionChains(browser)\
        .key_down(Keys.CONTROL).send_keys(k).key_up(Keys.CONTROL).perform()

 def esc(browser, k):
    """Send key combination esc+(k)"""
    ActionChains(browser)\
        .key_down(Keys.ESCAPE).send_keys(k).key_up(Keys.ESCAPE).perform()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,25 @@
		importos
Copy link Member takluyverJun 2, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Let's call the file`test_find_and_replace.py` - we'll probably later want to add tests that aren't doing apply all.
		importpytest


		deftest_find_and_replace_apply_all(notebook):
		""" test find and replace on all the cells """
		cell_0,cell_1,cell_2,cell_3="hello","hellohello","abc","ello"

		find_str="ello"# string to replace
		replace_str="foo"# string to replace to

		# set the contents of the cells
		notebook.add_cell(index=0,content=cell_0);
		notebook.add_cell(index=1,content=cell_1);
		notebook.add_cell(index=2,content=cell_2);
		notebook.add_cell(index=3,content=cell_3);

		# replace the strings
		notebook.find_and_replace(index=0,find_txt=find_str,replace_txt=replace_str,replace_all=True)

		# check content of the cells
		assertnotebook.get_cell_contents(0)==cell_0.replace(find_str,replace_str)
		assertnotebook.get_cell_contents(1)==cell_1.replace(find_str,replace_str)
		assertnotebook.get_cell_contents(2)==cell_2.replace(find_str,replace_str)
		assertnotebook.get_cell_contents(3)==cell_3.replace(find_str,replace_str)
Original file line number	Diff line number	Diff line change
		@@ -1,5 +1,5 @@
		import os

		import time
		from selenium.webdriver import ActionChains
		from selenium.webdriver.common.by import By
		from selenium.webdriver.common.keys import Keys
Expand DownExpand Up		@@ -100,6 +100,20 @@ def focus_cell(self, index=0):
		self.to_command_mode()
		self.current_cell = cell

		def find_and_replace(self, index=0, find_txt='', replace_txt='', replace_all=False):
Copy link Member takluyverJun 2, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Looks like the`replace_all` parameter doesn't do anything. It's fine to drop it for now - it can always be added back when there's a test that wants to use it.
		self.focus_cell(index)
		esc(self.browser, 'F')
		time.sleep(1) # TODO: find better way to fill the find and replace form
Copy link Member takluyverMay 27, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Are there any specific elements on the form? We can wait for an element to appear. Copy link ContributorAuthor arovitMay 31, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Hmm, I don't want to comment now before trying again (I rem trying the wait logic while working on this, but couldn't get the wait working because I couldn't find any specific element, but let me retry)
		self.browser.find_elements_by_css_selector("button.btn.btn-default.btn-sm")[2].click()
Copy link Member takluyverMay 27, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. What's this doing? Copy link ContributorAuthor arovitMay 31, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This code is basically for clicking double "upside down" arrow (third button) on the find and replace form to enable global replace. It's kinda hacky way of doing it, since the buttons don't have any specific ids on them which made it harder to fetch them directly. But let me will revisit this commit to see if we can make it more robust. Thanks ! Copy link Member takluyverMay 31, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. We could add an ID, so long as that's not going to cause problems. If you do, try closing and reopening the dialog a few times so it's created several successive buttons with the same ID, and check that the button still works.
		JS = "document.getElementsByClassName('form-control input-sm')[0].setAttribute('value', '%s')"%find_txt
Copy link Member takluyverMay 27, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. We shouldn't need to construct JS just to set the value of a form field like this, I think. Copy link ContributorAuthor arovitMay 31, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. right, let me see how I can make it better.
		self.browser.execute_script(JS)
		JS = "document.getElementsByClassName('form-control input-sm')[1].setAttribute('value', '%s')"%replace_txt
		self.browser.execute_script(JS)
		self.body.send_keys(Keys.TAB)
		self.body.send_keys(Keys.TAB)
		self.body.send_keys(Keys.ENTER)
		time.sleep(1)

		def convert_cell_type(self, index=0, cell_type="code"):
		# TODO add check to see if it is already present
		self.focus_cell(index)
Expand DownExpand Up		@@ -258,3 +272,9 @@ def ctrl(browser, k):
		"""Send key combination Ctrl+(k)"""
		ActionChains(browser)\
		.key_down(Keys.CONTROL).send_keys(k).key_up(Keys.CONTROL).perform()

		def esc(browser, k):
		"""Send key combination esc+(k)"""
		ActionChains(browser)\
		.key_down(Keys.ESCAPE).send_keys(k).key_up(Keys.ESCAPE).perform()
Copy link Member takluyverMay 27, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This isn't necessary -`Esc` isn't used as a modifier key that you have to hold down while pressing other keys. Just call`self.to_command_mode()` and then send the other keys as normal. Copy link ContributorAuthor arovitMay 31, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I see okay. Makes sense, will call self.to_command_mode()