Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Prefer IP address over hostname when available#3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
takluyver merged 2 commits intojupyter:masterfromtakluyver:url-prefer-ipaddr
May 5, 2018

Conversation

@takluyver
Copy link
Member

Following discussion on#3356.

@evandam@cyberwillis please let me know if you think this is a good idea. I haven't encountered the same issues as either of you, so I don't want to merge this without some confirmation that it's actually an improvement!

@takluyver
Copy link
MemberAuthor

And are there any other values forself.ip like '0.0.0.0', which can't be directly used?

@cyberwillis
Copy link

cyberwillis commentedMay 4, 2018•
edited
Loading

To me its working fine with this code.
I replicate your changes locally here and tested:

0.0.0.0 : 8888 => container_name : 8888' ' : 8888 => localhost : 8888127.0.0.1:8888 => 127.0.0.1 : 8888xxx.xxx.xxx.xxx : 8888 => xxx.xxx.xxx.xxx : 8888'*' : 8888 => container_name : 8888

Thanks

[UPDATED@evandam ]

Copy link

@cyberwilliscyberwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To me this changes are working great !
I tested all the cases.

@evandam
Copy link
Contributor

Looks great to me! Does this handle when you do something like--ip='*'? If I recall it's the same thing as passing0.0.0.0, too.

@cyberwillis
Copy link

cyberwillis commentedMay 5, 2018•
edited
Loading

Yes, it does. I have tested earlier.

@evandam
Copy link
Contributor

Just read that after I asked. I'm all for this!

cyberwillis reacted with thumbs up emoji

@cyberwillis
Copy link

:)

evandam reacted with hooray emoji

@takluyvertakluyver added this to the5.5 milestoneMay 5, 2018
@takluyver
Copy link
MemberAuthor

Thanks both! In it goes.

@takluyvertakluyver merged commit11743f1 intojupyter:masterMay 5, 2018
@takluyvertakluyver deleted the url-prefer-ipaddr branchMay 5, 2018 05:35
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 1, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@cyberwilliscyberwilliscyberwillis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.5

Development

Successfully merging this pull request may close these issues.

3 participants

@takluyver@cyberwillis@evandam
[8]ページ先頭
©2009-2025 Movatter.jp