Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Displays Warning Message if Cookies Not Enabled#3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
takluyver merged 13 commits intojupyter:masterfromnyu-ossd-s18:cookies
Apr 10, 2018

Conversation

@ckilcrease
Copy link
Contributor

This addresses#2337

Adds a check for cookies using navigator.cookiesEnabled (tested in Chrome 64.0.3282.186, works both when cookies are blocked altogether and when only blocked for localhost:8888). If the user doesn't have cookies enabled, a request to enable cookies appears in body of modal as follows:

screen shot 2018-04-06 at 12 34 51 pm

rosaswaby reacted with thumbs up emoji
@takluyver
Copy link
Member

takluyver commentedApr 7, 2018
edited
Loading

Thanks, this is looking good. A couple of things:

  • Could we ask you to do this with your editor configured not to strip trailing spaces? If you look atthe changes, you'll see that >100 lines are changed because of automatically removed whitespace. This can cause unnecessary merge conflicts, and it makesgit blame less useful.
  • Having two buttons seems redundant; the user doesn't really have two options. Maybe get rid of the 'OK' button in this case?
  • I think it would be good for the message to mention that Jupyter needs cookies to work. Also, if we can find a good website explaining what cookies are and how to make sure they're enabled on different browsers, we could link to it.

@ckilcrease
Copy link
ContributorAuthor

Definitely - we will get started on those changes! 👍

@ckilcrease
Copy link
ContributorAuthor

ckilcrease commentedApr 8, 2018
edited
Loading

Made most of the changes discussed, but I wanted to check in re: websites on cookies before choosing one; I thinkMDN does a good job of explaining them concisely, although parts of the page go into details that might not really concern users (such as creating cookies, scope, etc.) - if this would be an issue, I can find one that only presents the overview/relevant details. (Also, accidentally clicked "close and comment" earlier - apologies for that!)

@ckilcreaseckilcrease reopened thisApr 8, 2018
@takluyver
Copy link
Member

Thanks!

I like MDN, but I think it's too technical for this. If people want help enabling cookies, they're probably going to be put off by all the detail. I was thinking more of pages likethis one orthis one. (Those are just the first ones I found with a quick search; there may well be better ones out there).

@ckilcrease
Copy link
ContributorAuthor

That makes sense - I looked at a few other articles as well, but it seems like the WikiHow one is the most accurate (many seem to be outdated) and easy to follow, so at the moment I have that one linked as follows:

screen shot 2018-04-10 at 11 45 31 am

ashleytqy reacted with hooray emoji

@takluyvertakluyver added this to the5.5 milestoneApr 10, 2018
@takluyver
Copy link
Member

Thanks@ckilcrease and@rosaswaby :-)

@takluyvertakluyver merged commitca3e7a3 intojupyter:masterApr 10, 2018
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 1, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.5

Development

Successfully merging this pull request may close these issues.

3 participants

@ckilcrease@takluyver@rosaswaby

[8]ページ先頭

©2009-2025 Movatter.jp