Was it actually computing the etags wrong, or was it the Cache-Control change that fixed it? Looking through tornado's code, it looks like it computes the etag by hashing the content when we callself.finish(), which I think should work.

(I'd assumed before that tornado wasn't setting etags by default except for static files, and that we could try setting it from our code)

I think the Cache-Control fixed it – I'll remove thecompute_etag method!

hi@takluyver ! does this look good to you?

Oh, sorry, it dropped off my radar. It does look good, thanks. I assume you've tested that it fixes the issue?

I think we might also need the same in therespond_zip() function; that's used when nbconvert produces multiple files, so we assemble them into a zip file to be downloaded.

@takluyver yup! i’ll also add the change torespond_zip() !

Thanks :-)