NotificationsYou must be signed in to change notification settings
Fork5.5k
Star12.8k

Undo patches in teardown before attempting to delete files#3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mpacer merged 2 commits intojupyter:masterfromtakluyver:appveyor-path-fails

Mar 22, 2018

Merged

Undo patches in teardown before attempting to delete files#3459

mpacer merged 2 commits intojupyter:masterfromtakluyver:appveyor-path-fails

Mar 22, 2018

Conversation

Copy link

Member

takluyver commentedMar 22, 2018

Deleting the directory can fail on windows, which leaves the patches in place for other tests which run afterwards. Unfortunately we can't useaddCleanup() with class-level setup/teardown, AFAIK.

This will probably still fail at first (unless the original issue is random), but it should see one test failure on Appveyor rather than 5.

Undo patches in teardown before attempting to delete files

2a47614

takluyver added this to the5.5 milestone

Mar 22, 2018

Copy link

MemberAuthor

takluyver commentedMar 22, 2018

As expected, that now has only one failure. Now to figure out what causes that.

Try testing redirect without requesting target file

acbeaf8

Copy link

MemberAuthor

takluyver commentedMar 22, 2018

Hmm, it seems that that fixed it. I was kind of hoping that it wouldn't, because I think that means that something isn't getting cleaned up following a request for a static file, so the file is left 'open'. Tornado devs have told us previously that they don't officially support Windows, so we may have to work around this. But for now this makes tests pass on Appveyor.