Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix going back to root directory with history in notebook list#3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@takluyver
Copy link
Member

Bug found during pair programming with@mpacer

@takluyvertakluyver added this to the5.5 milestoneMar 9, 2018
@mpacermpacer mentioned this pull requestMar 9, 2018
@takluyver
Copy link
MemberAuthor

To elaborate a bit, the bug manifests when you click into a subdirectory from the tree view, and then use the back button to return to the first view that was loaded. The history entry for this has an empty state object, but that's still truthy in Javascript, so it was taking.path from it, which was undefined.

While fixing this, we realised that the fallback was also to the server root directory instead of the first directory loaded - they're normally the same, but don't have to be. So that is also fixed.

@takluyver
Copy link
MemberAuthor

I'll merge this tomorrow unless anyone wants more time to review it.

@takluyvertakluyver merged commit276474a intojupyter:masterMar 15, 2018
@takluyvertakluyver deleted the notebooklist-back-to-start branchMarch 15, 2018 14:53
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 2, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.5

Development

Successfully merging this pull request may close these issues.

1 participant

@takluyver

[8]ページ先頭

©2009-2025 Movatter.jp