- Notifications
You must be signed in to change notification settings - Fork5.5k
Fix going back to root directory with history in notebook list#3411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Bug found during pair programming with@mpacer
takluyver commentedMar 9, 2018
To elaborate a bit, the bug manifests when you click into a subdirectory from the tree view, and then use the back button to return to the first view that was loaded. The history entry for this has an empty state object, but that's still truthy in Javascript, so it was taking While fixing this, we realised that the fallback was also to the server root directory instead of the first directory loaded - they're normally the same, but don't have to be. So that is also fixed. |
takluyver commentedMar 13, 2018
I'll merge this tomorrow unless anyone wants more time to review it. |
Bug found during pair programming with@mpacer