- Notifications
You must be signed in to change notification settings - Fork5.5k
#1097 Add close and halt to shortcut menu#3314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| }; | ||
| // finish with close on success or failure | ||
| that.notebook.session.delete(close_window,close_window); | ||
| that.notebook.close_and_halt(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Now that there's an action for this, it should be possible to remove the handler function, and connect it viaid_actions_dict below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok Thanks! Would it be helpful to change the id from 'kill_and_exit' to 'close_and_halt' in the html for consistency? or vice versa?
takluyver commentedFeb 7, 2018
There are some tests failing because they look for the |
Hi this is my first pull request for the jupyter notebook project! This is a fix for issue#1097. I appreciate any feedback.