Jun 20, 2018 · Apr 29, 2018 · Apr 29, 2018 · Apr 29, 2018 · May 12, 2018 · May 13, 2018
diff --git a/notebook/static/notebook/js/notebook.js b/notebook/static/notebook/js/notebook.js
        }
        var that = this;
        var current_dir = $('body').attr('data-notebook-path').split('/').slice(0, -1).join("/");
        current_dir = current_dir?currend_dir + "/": "";
        current_dir = current_dir?current_dir + "/": "";
        var dialog_body = $('<div/>').append(
            $('<p/>').addClass('save-message')
                .text(i18n.msg._('Enter a notebook path relative to notebook dir'))
                             };
                            return that.contents.save(nb_path, model)
                                .then(function(data) {
                                    window.open(data.path, '_blank');
                                    d.modal('hide');
                                    that.notebook_name = data.name;
                                    that.notebook_path = data.path;
                                    that.session.rename_notebook(data.path);
                                    that.events.trigger('notebook_renamed.Notebook', data);

                                },function(error) {
                                   console.error(i18n.msg._(error.message || 'Unknown error saving notebook'));
                                });
                },
            },
            open : function () {
                d.find('input[type="text"]').keydown(function (event) {
                    if (event.which === keyboard.keycodes.enter) {
                        d.find('.btn-primary').first().click();
                        return false;
                    }
                });
                d.find('input[type="text"]').focus().select();
             }
         });
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2854,7 +2854,7 @@ define([
		}
		var that = this;
		var current_dir = $('body').attr('data-notebook-path').split('/').slice(0, -1).join("/");
		current_dir = current_dir?currend_dir + "/": "";
		current_dir = current_dir?current_dir + "/": "";
		var dialog_body = $('<div/>').append(
		$('<p/>').addClass('save-message')
		.text(i18n.msg._('Enter a notebook path relative to notebook dir'))
Expand DownExpand Up		@@ -2896,7 +2896,12 @@ define([
		};
		return that.contents.save(nb_path, model)
		.then(function(data) {
		window.open(data.path, '_blank');
		d.modal('hide');
		that.notebook_name = data.name;
		that.notebook_path = data.path;
		that.session.rename_notebook(data.path);
		that.events.trigger('notebook_renamed.Notebook', data);

		},function(error) {
		console.error(i18n.msg._(error.message \|\| 'Unknown error saving notebook'));
		});
Expand DownExpand Up		@@ -2924,6 +2929,12 @@ define([
		},
		},
		open : function () {
		d.find('input[type="text"]').keydown(function (event) {
		if (event.which === keyboard.keycodes.enter) {
		d.find('.btn-primary').first().click();
		return false;
		}
		});
		d.find('input[type="text"]').focus().select();
Copy link Member takluyverApr 30, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This currently selects the path pre-filled in the input, which is not ideal. Can we make it put the cursor at the end of the input already there?
		}
		});
Expand Down