Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change the path to create notebooks in when navigating directories#3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Carreau merged 2 commits intojupyter:masterfromtakluyver:i3263
Jan 27, 2018

Conversation

@takluyver
Copy link
Member

Closesgh-3263
Closesgh-3248

There's still an issue where the dashboard goes back to showing the root directory when you create a notebook. I'll look into that later.

kylemcdonald and dmitryhd reacted with thumbs up emoji
@takluyvertakluyver added this to the5.3.2 milestoneJan 25, 2018
@takluyver
Copy link
MemberAuthor

I haven't fully understood the issue with the list showing the previous directory yet, but what I have found is that:

  • I can trigger it by creating a new text file or a directory, as well as a new notebook.
  • Theonpopstate() handler we add is getting called, for some reason.

@takluyver
Copy link
MemberAuthor

Educated guesswork led me to useevent.preventDefault() on the links that make new files and folders, which seems to fix the issue with the files list jumping back to a previous state.

@takluyver
Copy link
MemberAuthor

@gnestor@Carreau if you have a chance to review this, I think the issue is worth doing a 5.3.2 bugfix release for. I can make the release tomorrow if this gets merged.

@Carreau
Copy link
Member

Haven't looked at notebook codebase in a while but this look good to me.
Happy if we make a 5.3.2.

@CarreauCarreau merged commitb96d758 intojupyter:masterJan 27, 2018
@takluyvertakluyver deleted the i3263 branchJanuary 27, 2018 17:54
@takluyvertakluyver modified the milestones:5.3.2,5.4Jan 27, 2018
@gnestor
Copy link
Contributor

Thanks for fixing this@takluyver! I think that releasing a patch for this is a good idea as it's a regression that was reported by several people. Let me know if I can help with that 👍

@takluyver
Copy link
MemberAuthor

I've released 5.4 to PyPI with the fix (and a few other changes). Now to update conda-forge.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 2, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.4

3 participants

@takluyver@Carreau@gnestor

[8]ページ先頭

©2009-2025 Movatter.jp