Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add Folder for document translation#3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jzf2101 merged 1 commit intojupyter:masterfromChungJooHo:master
Nov 20, 2017

Conversation

@ChungJooHo
Copy link
Contributor

As you suggested I first add translation folder. And I added my translation 'Readme.md' in Korean.
Thank you for your suggestion. I will steadily update docs.

I first add my translation 'Readme.md' in Korean
@rgbkrk
Copy link
Member

/cc@willingc

Copy link
Member

@willingcwillingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@willingc
Copy link
Member

Thanks!

I'll leave for@jzf2101 to review and merge :-)

@gnestor
Copy link
Contributor

Another options is to use a file name convention likeREADME.ko-KR.md 👍

@rgbkrk
Copy link
Member

Another options is to use a file name convention like README.ko-KR.md

Oh that's true for the base. Then we would just make that folder for thedocs/ translations.

@ChungJooHo
Copy link
ContributorAuthor

Okay!! Then I will just add folder for translations and rename readme to readme.ko-KR.md :)

@ChungJooHo
Copy link
ContributorAuthor

But I think making each language folders like docs/transation/ko-KR is more comfortable to access docs .

gnestor, rgbkrk, and daikikatsuragawa reacted with thumbs up emoji

@jzf2101
Copy link
Contributor

@ChungJooHo this is great thanks!

@jzf2101jzf2101 merged commitf34cb00 intojupyter:masterNov 20, 2017
@jzf2101jzf2101 removed their request for reviewNovember 20, 2017 20:58
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@rgbkrkrgbkrkrgbkrk approved these changes

@willingcwillingcwillingc approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@ChungJooHo@rgbkrk@willingc@gnestor@jzf2101
[8]ページ先頭
©2009-2025 Movatter.jp