- Notifications
You must be signed in to change notification settings - Fork5.5k
I18n README.md improvement#2962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
takluyver merged 2 commits intojupyter:masterfromJocelynDelalande:i18n-readme-improvementOct 23, 2017
Merged
I18n README.md improvement#2962
takluyver merged 2 commits intojupyter:masterfromJocelynDelalande:i18n-readme-improvementOct 23, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This README.md is the only documentation for i18n setup, let's enhanceit.Modifications include:- make the writing style less personal- fix markdown (syntax, headings…)- clearly separate the usage guide from the known bugs and future perspectives (as this guide is now in master branch, it is no longer relevant to say that it is an experimental thing)- rewordings
Make the commands listings shorter and easier to focus on what matters.
Member
takluyver commentedOct 23, 2017
Thanks, I think this looks good, and I'm glad you're interested in working on it. |
ContributorAuthor
JocelynDelalande commentedOct 23, 2017
@takluyver you are welcome, thanks for your work on jupyter! |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the i18n effort started by@JCEmmons with#2140 (thanks a lot for that!!), I'd like to add my tiny contribution, smoothing the (quite rough at the moment) i18n documentation.
I know this is just a step, and that next steps are to improve tooling and script more things in the translation process. But I believe a clearer documentation is an interesting step anyway :-). At least, it helped me to understand better the 18n mechanism as introduced in#2140 (I'm working on french translation).
What do you think ?