- Notifications
You must be signed in to change notification settings - Fork5.5k
Add 5.1.0 to changelog#2723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
takluyver left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for doing this - there are a few bits of wording that I think could be clearer, but otherwise +1
docs/source/changelog.rst Outdated
| - Include metadata when copying a cell (:ghpull:`2349`). | ||
| - Stop notebooks from command line (:ghpull:`2388`). | ||
| - Improve "View" and "Edit" file handling in dashboard (:ghpull:`2449`) and (:ghpull:`2402`). | ||
| - Load custom.js before ``app_initialized.NotebookApp`` is triggered (:ghpull:`2710`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is misleading. We haven't changed the order of loading things - instead we added a promise as a new mechanism to run code after the application is initialized.
docs/source/changelog.rst Outdated
| - Add session-specific favicons (notebook, terminal, file) (:ghpull:`2452`). | ||
| - Add /api/shutdown handler (:ghpull:`2507`). | ||
| - Include metadata when copying a cell (:ghpull:`2349`). | ||
| - Stop notebooks from command line (:ghpull:`2388`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it's clearer to say 'notebook servers'.
docs/source/changelog.rst Outdated
| - Preliminary i18n implementation (:ghpull:`2140`). | ||
| - Expose URL with auth token in notebook UI (:ghpull:`2666`). | ||
| - Fix search background style (:ghpull:`2387`). | ||
| - List running notebooks with ``--allow-root`` (:ghpull:`2421`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think the point of this PR is that you can list running notebook servers without needing--allow-root, whereas previously it was doing that check when it wasn't necessary.
docs/source/changelog.rst Outdated
| - Include metadata when copying a cell (:ghpull:`2349`). | ||
| - Stop notebook server from command line (:ghpull:`2388`). | ||
| - Improve "View" and "Edit" file handling in dashboard (:ghpull:`2449`) and (:ghpull:`2402`). | ||
| - Provide a Promise implementation for ``app_initialized.NotebookApp`` event (:ghpull:`2710`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Better, but still not very clear. How about "Provide a promise to replace use of theapp_initialized.NotebookApp event"?
takluyver commentedAug 4, 2017
Thanks |
Uh oh!
There was an error while loading.Please reload this page.
Preview:
--allow-root(check allow_root after calling super #2421)./filespath except for.htmland .svg` #2449) and (Specifycharset=UTF-8when serving non-base64 files #2402).app_initialized.NotebookAppis triggered (Add a promise for app_initialized event. #2710).--MappingKernelManager.cull_idle_timeout(Cull idle kernels #2215).See the 5.1 milestone on GitHub for a complete list ofissues andpull requests involved in this release.