- Notifications
You must be signed in to change notification settings - Fork5.5k
Expose URL with auth token in notebook UI#2666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This provides a crude way to copy the link from one browser (right clickthe Jupyter logo) to get authenticated in another browser.Closesjupytergh-2094
notebook/templates/page.html Outdated
| <divid="header"> | ||
| <divid="header-container"class="container"> | ||
| <divid="ipython_notebook"class="nav navbar-brand pull-left"><ahref="{{default_url}}"title='{% trans %}dashboard{% endtrans %}'>{% block logo %}<imgsrc='{{static_url("base/images/logo.png") }}'alt='Jupyter Notebook'/>{% endblock %}</a></div> | ||
| <divid="ipython_notebook"class="nav navbar-brand pull-left"><ahref="{{default_url}}?token={{token}}"title='{% trans %}dashboard{% endtrans %}'>{% block logo %}<imgsrc='{{static_url("base/images/logo.png") }}'alt='Jupyter Notebook'/>{% endblock %}</a></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This exposes the login token on the login page, so unauthenticated users can just click this link to login. We should make sure to only include this if the page being served is already authenticated, and only when the token is defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good job one of us is thinking about this! ;-)
takluyver commentedJul 20, 2017
Should be fixed now. I'm using the same conditions ( |
This provides a crude way to copy the link from one browser (right click the Jupyter logo) to get authenticated in another browser.
Closesgh-2094