- Notifications
You must be signed in to change notification settings - Fork5.5k
Bidi support#2357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Bidi support#2357
Uh oh!
There was an error while loading.Please reload this page.
Conversation
blink1073 commentedApr 3, 2017
This approach looks great! Having a user toggle for locale makes sense to me. |
blink1073 commentedApr 3, 2017
pinging@ellisonbg for design consideration. |
samarsultan commentedApr 9, 2017
Could you please review ? |
gnestor commentedJul 27, 2017
@samarsultan Can you please resolve the merge conflicts for this PR? What is the current status? We are closing in on 5.1 release and if this is complete, then let's try to get it in there! |
samarsultan commentedAug 1, 2017
@gnestor ,Conflicts have been resolved. The current status is having a mirrored UI with loading the dedicated Locale form momentJS. |
gnestor commentedAug 1, 2017
@samarsultan Excellent!! How do I set locale or enable mirroring? |
samarsultan commentedAug 1, 2017
For now, you can do it by just setting the browser language to "ar" . However, it will be better to have a user toggle for locale as proposed above. |
gnestor commentedAug 1, 2017
samarsultan commentedAug 1, 2017
gnestor commentedAug 2, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
gnestor commentedAug 3, 2017
I'm going to mark this as 5.2 and will merge into master as soon as 5.1 is released. This will everyone a chance to use it before it's released. |
gnestor commentedSep 15, 2017
5.1 is released so let's merge this and start testing it! |
| if(_isMirroringEnabled()){ | ||
| $("body").attr("dir","rtl"); | ||
| } | ||
| requirejs(['components/moment/locale/'+_uiLang()], function (err){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ithink we need to special caseen anden-us since the files are not there and are the builtins from moment:moment/moment#2081
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like you already took care of it! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh yeah I should have noted that again here. Good to go now.
gnestor commentedOct 9, 2017
Notebook 5.2.0rc1 is available on PyPI so please give it a try 👍:
|
samarsultan commentedNov 27, 2017
gnestor commentedDec 1, 2017
@takluyver Should we add the following fromhttps://github.com/jupyter/notebook/blob/master/notebook/i18n/README.md#how-the-language-is-selected- to the README?
|
takluyver commentedDec 1, 2017
I'd focus on getting the machinery for building and contributing translations in place first. |



Uh oh!
There was an error while loading.Please reload this page.
Hello@Carreau ,
This pull request contains the bidi work and fixes the UI mirroring issues.
Here are some functions added such : LoadLocale -> to load the required locale that is defined atMomentjs based on the browser preferences setting . I propose to leave it to the user selection rather than the browser preferences and to create a UI component to toggle among the list of locales.
ForNumeric Shaping : I need another component to toggle between the options.
With respect toNational Calendar , I found an external plugin at Momentjs calledmoment-hijri that is dedicated to Hijri-calendar so I removed the related functions that were mentioned at the design. Actually I didn't findmoment at the documentation . I'll put the links below :
http://momentjs.com/docs/#/plugins/hijri/
https://github.com/xsoh/moment-hijri
Could you please review ?
Waiting your comments. Thanks !