Thanks for working on this!

I'm aiming to release 5.0 soon (hopefully this week), so I think this will probably miss that release, but I'd like to try to get it in for 5.1.

We don't really have a schedule for releases, I'm afraid. If the changes in 5.0 cause some problems we need to fix, there might be a 5.1 in a couple of weeks, but in that case most of the new features planned for 5.1 would be targeted to 5.2 instead.

If you want some target dates, I'd hope to have the JEP and this infrastructure merged by the end of the month.

How do we go about making this so it can be merged? I've still got a few small things that can be worked on here, but the vast majority of the work here is complete. Please advise.

Still waiting....@takluyver can you comment pls?

• We're still getting notebook 5.0 out, so this has been waiting for that to happen.
• There are merge conflicts now - can you rebase the branch on master? If you're not familiar with rebasing, I can provide a brief outline of how I usually do it.

To rebase and resolve merge conflicts, I usually:

• Ensure master is up to date -git checkout master andgit pull (from jupyter/notebook, rather than your fork on Github)
• Check out this branch again -git checkout jep16
• Rungit rebase master
• Each time it reaches a conflict, it will stop and tell you about it. Rungit status to see which files have conflicts. Fix them in a text editor (look for markers like>>>>> and<<<<<). Thengit add the files you've fixed, and rungit rebase --continue.
• Once it has got through all the commits, it will stop without a message about conflicts.
• Then you need to force push the rebased branch -git push -f <my_remote> jep16 (replace<my_remote> with the name it has for your Github fork of the repo.

I'll work on the travis-ci failures next week.

I'm looking at the logs from the js tests in Travis CI, and I have no idea how to go about debugging here. Can someone shed some light on what might be going on?

😕 the errors look like this - anyone got any ideas?

Test file: /home/travis/build/jupyter/notebook/notebook/tests/services/session.jsTimeout for http://localhost:8888/a@b/Is the notebook server running?FAIL "#kernel-python2 a, #kernel-python3 a" still did not exist in 10000ms#    type: uncaughtError#    file: /home/travis/build/jupyter/notebook/notebook/tests/services/session.js#    error: "#kernel-python2 a, #kernel-python3 a" still did not exist in 10000ms#    stack: not provided

Aha, I've found the issue. You've gotutils.i18n in a few places where it should be justi18n.

Thanks@takluyver for your help! That's what happens when you try to refactor things.....

The tests are now producing a whole lot ofReferenceError: Can't find variable: utils [object Arguments]

Even without running the tests, you may be able to trigger some of these errors by running the notebook in a browser with the Javascript console open.

It would be really nice if we could go ahead and get this merged, as I'm getting tired of resolving merge conflicts.

Sorry for the delay@JCEmmons . It's the end of the day over here now, but I'll try to have a look at this tomorrow.

Sorry, most of today got taken up working on Windows packaging of some magnetic simulation code. I haven't forgotten about this, though.

@JCEmmons thanks for addressing the review! I think this is in good shape to merge, with one exception I just noticed while testing this out locally: Some of the changes here have mixed in some tab indentation instead of spaces, and added Windows CRLF line endings in a few places. This is part of why the diff on a few files looks so large. You can tell git tohandle CRLF automatically with:

git config --global core.autocrlf true

to avoid this sort of problem in the future. If you check the "Allow edits from maintainers" box on the right:

I can do the last conflict resolution and fix these little things and get this merged. Or you can pull frommy branch, if you prefer.

Hi@minrk and thanks.... Allow edits from maintainers is already enabled, so if you can handle the last merge conflict and do the merge I would appreciate it greatly!!! Thanks......

We can continue to iterate on this in master as things come up. Thanks for your work and patience!

Due to the issues with line endings and whitespace changes, I chose to squash this PR rather than deal with a complicated rebase. Hopefully we can catch similar issues earlier in subsequent PRs.

Hi@JCEmmons! I'm about to publish a release candidate for notebook 5.1 and I noticed the following error when opening a new terminal (in the Jupyter Notebook):

Does this make sense to you?

I installed RC1 and I can't reproduce this -@gnestor did you get it worked out?

It doeslook like jed is listed in bower.json - maybe it was a matter of clearing out some cache?

I'm even seeing this in master 🤔 I don't see this when opening notebooks, just terminals.

I'm seeing the same missing jed error breaking the jupyter_nbextensions_configurator standalone page atJupyter-contrib/jupyter_nbextensions_configurator#43, using a pip-installed notebook 5.1.0 😢