[Fix] jsx-key: detect missing keys in logical expressions#3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

yalperg wants to merge3 commits intojsx-eslint:master

base:master

Choose a base branch

fromyalperg:fix/js-key/logical-expression

Open

[Fix] jsx-key: detect missing keys in logical expressions#3932

yalperg wants to merge3 commits intojsx-eslint:masterfromyalperg:fix/js-key/logical-expression

Conversation

Copy link

yalperg commentedJun 6, 2025

Fix:#3931

yalperg added2 commits

June 6, 2025 23:56

[Refactor]jsx-key: use isJSX util function instead of shouldCheckNode

f9ee7ed

[Fix]jsx-key: detect missing keys in logical expressions

7b2bcab

Copy link

codecovbot commentedJun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.80%. Comparing base(f2869fd) to head(7b2bcab).

Additional details and impacted files

@@            Coverage Diff             @@##           master    #3932      +/-   ##==========================================- Coverage   97.84%   97.80%   -0.04%==========================================  Files         136      133       -3       Lines       10008     9999       -9       Branches     3717     3717              ==========================================- Hits         9792     9780      -12- Misses        216      219       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.