Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[New] forbid-dom-props: AdddisallowedValues option for forbidden props#3877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
makxca wants to merge1 commit intojsx-eslint:master
base:master
Choose a base branch
Loading
frommakxca:master

Conversation

makxca
Copy link

@makxcamakxca commentedJan 11, 2025•
edited
Loading

AdddisallowedValues for disallowing only certain values for certain props

Discussion:#3876

@codecovCodecov
Copy link

codecovbot commentedJan 11, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base(efc021f) to head(a2e9dac).

Additional details and impacted files
@@            Coverage Diff             @@##           master    #3877      +/-   ##==========================================+ Coverage   97.64%   97.66%   +0.02%==========================================  Files         133      136       +3       Lines        9966     9986      +20       Branches     3703     3706       +3     ==========================================+ Hits         9731     9753      +22+ Misses        235      233       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Member

@ljharbljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Using a regex is a nonstarter; see#3876 (comment)

@makxcamakxcaforce-pushed themaster branch 2 times, most recently froma7911e2 tod52c0f1CompareJanuary 12, 2025 21:53
@makxcamakxca marked this pull request as ready for reviewJanuary 12, 2025 21:53
@makxcamakxcaforce-pushed themaster branch 2 times, most recently fromde2e1ea to5d3d27cCompareJanuary 13, 2025 07:30
@makxcamakxca changed the title[New] forbid-dom-props: AddvalueRegex option for forbidden props[New] forbid-dom-props: AdddisallowedValues option for forbidden propsJan 13, 2025
@makxcamakxca requested a review fromljharbJanuary 13, 2025 19:44
@makxca
Copy link
Author

makxca commentedJan 13, 2025•
edited
Loading

I changedvalueRegex todisallowedValues and fixed the comma in the docs

@makxca
Copy link
Author

makxca commentedMar 27, 2025•
edited
Loading

@ljharb, hello!

Opensource is practically new to me. Could you please guide me on this PR's flow? When can it be merged?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ljharbljharbAwaiting requested review from ljharb

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@makxca@ljharb
[8]ページ先頭
©2009-2025 Movatter.jp