Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

new rule: padding-lines-between-tags #3554#3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
etherealm13 wants to merge3 commits intojsx-eslint:master
base:master
Choose a base branch
Loading
frometherealm13:issue3554

Conversation

etherealm13
Copy link

@etherealm13etherealm13 changed the title[New]padding-lines-between-tags: add rule and test casesnew rule: padding-lines-between-tags #3554Jul 22, 2024
@etherealm13
Copy link
Author

@ljharb Let me know your thoughts.

@codecovCodecov
Copy link

codecovbot commentedJul 22, 2024

Codecov Report

Attention: Patch coverage is22.97297% with57 lines in your changes missing coverage. Please review.

Project coverage is 97.19%. Comparing base(c6fdccd) to head(6eeab0b).

FilesPatch %Lines
lib/rules/padding-lines-between-tags.js22.97%57 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #3789      +/-   ##==========================================- Coverage   97.75%   97.19%   -0.57%==========================================  Files         135      136       +1       Lines        9715     9789      +74       Branches     3527     3553      +26     ==========================================+ Hits         9497     9514      +17- Misses        218      275      +57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Member

@ljharbljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few changes, but in particular, it would need thorough tests.

@ljharbljharb marked this pull request as draftJuly 22, 2024 18:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ljharbljharbljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@etherealm13@ljharb
[8]ページ先頭
©2009-2025 Movatter.jp