fixed the schema of jsx-no-constructed-context-values.js#3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

noshiro-pf wants to merge2 commits intojsx-eslint:master

base:master

Choose a base branch

fromnoshiro-pf:patch-1

Draft

fixed the schema of jsx-no-constructed-context-values.js#3766

noshiro-pf wants to merge2 commits intojsx-eslint:masterfromnoshiro-pf:patch-1

Conversation

Copy link

noshiro-pf commentedJun 12, 2024

The schema forjsx-no-constructed-context-values did not seem to satisfy eslint'sRule.RuleMetaData["schema"] type, so I fixed it.

exportnamespaceRule{interfaceRuleMetaData{...schema?:JSONSchema4|JSONSchema4[]|undefined;...}

fix schema of jsx-no-constructed-context-values.js

9a0317d

noshiro-pf force-pushed thepatch-1 branch fromea36f37 to9a0317dCompare

June 12, 2024 07:39

fix schema and test

81e21f3

ljharb reviewed

Jun 12, 2024

View reviewed changes

tests/lib/rules/jsx-no-constructed-context-values.js

		@@ -41,7 +41,6 @@ ruleTester.run('react-no-constructed-context-values', rule, {
		},
		{
		code: 'function Component() { const foo = useMemo(() => { return {} }, []); return (<Context.Provider value={foo}></Context.Provider>)}',
		options: [{ allowArrowFunctions: true }],

Copy link

Member

ljharbJun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

i understand that this is incorrect and should be removed.

however, must it be? I'm asking specifically if the schema change causes this to fail. if that's the case for end users, then the schema change is breaking.