Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork24
Update Logo to X in README for Consistency#56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
DhairyaMajmudar commentedMar 10, 2025
@adityajha2005 Thanks for PR but as its seen the new logo of X won't look good when user is using GitHub in dark mode. Can you find a solution for this ? |
adityajha2005 commentedMar 10, 2025
@DhairyaMajmudar Alternatively, I can use an image with an opaque background like this |
DhairyaMajmudar commentedMar 10, 2025
Awsm! Go with this |
adityajha2005 commentedMar 10, 2025
mb, i'll just open another pr once it's done@DhairyaMajmudar |
DhairyaMajmudar commentedMar 10, 2025
Update in this PR only |
adityajha2005 commentedMar 10, 2025
GitHub README doesn’t support dynamic theme switching, so the X logo may not be visible properly in dark mode. To fix this, we’ll need an SVG with an opaque background. Let me know what you think! |
benjagm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added a comment.
| </a> | ||
| <a href="https://twitter.com/jsonschema" target="blank" style="margin-right: 5px;"> | ||
| <img align="center" src="https://raw.githubusercontent.com/rahuldkjain/github-profile-readme-generator/master/src/images/icons/Social/twitter.svg" alt="JSON SchemaTwitter" height="30" width="40" /> | ||
| <img align="center" src="./static/images/logos/x-social-media-logo-icon.svg" alt="JSON SchemaX" height="30" width="40" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we will need the full url here. Remember this is the readme of the repo, not the website.
DhairyaMajmudar commentedMay 19, 2025
@adityajha2005 any response on#56 (comment) ? Do you need any further help ? |
What kind of change does this PR introduce?
Enhancement : Updated logo of Twitter to X because of the rebranding
Issue Number:
Screenshots/videos:
Before :
After :
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?