Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Support underscore 1.7 and newer#332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
schmunk42 merged 1 commit intojson-editor:masterfromphillip-tsui-avalara:patch-2
May 28, 2019

Conversation

@phillip-tsui-avalara
Copy link
Contributor

@phillip-tsui-avalaraphillip-tsui-avalara commentedApr 4, 2019•
edited
Loading

The underscore library made a breaking change with version 1.7._.template() now returns a function.

https://underscorejs.org/#template

@schmunk42
Copy link
Collaborator

As far as I can see we need to specify the constraint first, likeunderscore < 1.7 for the current code and the make this change and also update the constraint tounderscore >= 1.7, right? Or is this somehow backward-compatible?

CC:@marc7000@pmk65

@pmk65
Copy link
Collaborator

As far as I can see we need to specify the constraint first, likeunderscore < 1.7 for the current code and the make this change and also update the constraint tounderscore >= 1.7, right? Or is this somehow backward-compatible?

I would say just support the latest version.

@schmunk42
Copy link
Collaborator

Sorry for taking so long ... this is an optional dependency, right?
Maybe we should also add a version note in the readme.

@pmk65
Copy link
Collaborator

Sorry for taking so long ... this is an optional dependency, right?
Maybe we should also add a version note in the readme.

It's one of the external template engines you can use.

@schmunk42schmunk42 self-requested a reviewMay 28, 2019 12:54
@schmunk42schmunk42 merged commit7270d88 intojson-editor:masterMay 28, 2019
schmunk42 added a commit that referenced this pull requestMay 28, 2019
@pmk65
Copy link
Collaborator

@phillip-tsui-avalara Do you have any schema examples that uses underscore templates, you could share?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@schmunk42schmunk42schmunk42 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phillip-tsui-avalara@schmunk42@pmk65
[8]ページ先頭
©2009-2025 Movatter.jp