- Notifications
You must be signed in to change notification settings - Fork693
Fix/issues 1666#1667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
bassmanitram wants to merge6 commits intojson-editor:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Fix/issues 1666#1667
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Main enhancements:* Cleanup and alignment of Table and Array editor code* New option `array_copy_in_place` determines whether a copied element is placed after the element it is copied from, or placed at the end of the array. For `array` the default value is `false` corresponding to the existing behaviour. For `table` the default value is `true` corresponding to the existing behaviour.
Rather than the potentially expensive validation of a valueagainst multiple schemata, how about we provide the path toa value field that tells you the type and an array of values inthe order of declaration!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
utilities.jscheckBooleanOptionin order to not repeat the pain of checking if options are set and, if so what are they set to!getValueByPathto get a value from a model by its string path (there may be a better way to do this)array.js:array_copy_in_placeto allow for both the originalarray.jsbehaviour and thetable.jsbehavioron_copy_item_label_pathoption which, if set, allows the editor to modify the label of the copied item by appendingCopyto it.table.jsarray.js(now) implements adequatelymultiple.jstype_pathandtype_valuesso that the schema can tell the editor where to look for a value that indicates the "type" of an instance, and what editor it applies to - thus skipping the trial-and-error associated with schema determination.type_pathis the path within the value where the type indicator can be found,type_valuesis an array of possible values of that indicator, in the order of declaration in the schema (which translates into the order of sub-editor instances for the multiple editor).