Commit9e7ca51

authored

perf(parse): cache length, return early (#144)

1 parentd6f39b0 commit9e7ca51Copy full SHA for 9e7ca51

File tree

+14

-8

lines changed

+14

-8

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12,5 +12,6 @@`
`12`	`12`	`"support.google.com":"UUU=000=l0llUUlUllU0UlllU0U0U0UlU-Ulll0lUlllU0UUllUUlUUUlllllUUUU-UUllUllU0lUU0U0U00lU0UUlUl0l0lUUlUUUUl0lUU0UUllUlUlUUlUlUUUU0ll0l0UU0lllU0lllUUUU0U0lU0U00l0Ul0UlU-U0UllU00lUUl0U; UUU=000=l0llUUlUllU0UlllU0U0U0UlU-Ulll0lUlllU0UUllUUlUUUlllllUUUU-UUllUllU0lUU0U0U00lU0UUlUl0l0lUUlUUUUl0lUU0UUllUlUlUUlUlUUUU0ll0l0UU0lllU0lllUUUU0U0lU0U00l0Ul0UlU-U0UllU00lUUl0U",`
`13`	`13`	`"www.google.com":"0U_UUU=0000-00-00-00; UUU=Ullll0Ullll0U0llUllU00U_lllll0lUUlUl0UllUlUUl0lUlUUUl00UUl; UUU=000=lUU0U0U0U0UllUUUlUUlUUU_UlUll_l0U0UU00lUlUlUlllllUUUl00UllllUU_0ll0UllUllUUU-UUUlllU0UlUlUllUlUllUll00UllU0U00llUUl0lU00lUlUUlllUl_U00UUlU0UU0UllUlUU0lUUlUUUl00lUUlUUUU0ll",`
`14`	`14`	`"youtu.be":"UUU=0; UUU=ll0UU-l0lUl; UUUUUUU_UUUU0_UUUU=0_llUUlUllU; UUUUUUU_UUUUUUU_UUUUUUUU=UlUUUlUUUlU%22",`
`15`		`-"youtube.com":"UUU=0; UUU=l0_UlUUUlUl; UUUUUUU_UUUU0_UUUU=UUUUlUUUlll; UUUUUUU_UUUUUUU_UUUUUUUU=UlUUUlUUUlU%22"`
	`15`	`+"youtube.com":"UUU=0; UUU=l0_UlUUUlUl; UUUUUUU_UUUU0_UUUU=UUUUlUUUlll; UUUUUUU_UUUUUUU_UUUUUUUU=UlUUUlUUUlU%22",`
	`16`	`+"example.com":""`
`16`	`17`	`}`

Lines changed: 8 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -96,16 +96,17 @@ function parse(str, options) {`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`varobj={};`
`99`		`-varopt=options\|\|{};`
`100`		`-vardec=opt.decode\|\|decode;`
`101`		`-`
	`99`	`+varlen=str.length;`
	`100`	`+// RFC 6265 sec 4.1.1, RFC 2616 2.2 defines a cookie name consists of one char minimum, plus '='.`
	`101`	`+varmax=len-2;`
	`102`	`+if(max<0)returnobj;`
	`103`	`+`
	`104`	`+vardec=(options&&options.decode)\|\|decode;`
`102`	`105`	`varindex=0;`
`103`	`106`	`vareqIdx=0;`
`104`	`107`	`varendIdx=0;`
`105`		`-varlen=str.length;`
`106`		`-varmax=len-2;`
`107`	`108`
`108`		`-while(index<max){`
	`109`	`+do{`
`109`	`110`	`eqIdx=str.indexOf('=',index);`
`110`	`111`
`111`	`112`	`// no more cookie pairs`
`@@ -142,7 +143,7 @@ function parse(str, options) {`
`142`	`143`	`}`
`143`	`144`
`144`	`145`	`index=endIdx+1`
`145`		`-}`
	`146`	`+}while(index<max);`
`146`	`147`
`147`	`148`	`returnobj;`
`148`	`149`	`}`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,10 @@ describe('cookie.parse(str)', function () {`
`27`	`27`	`assert.deepEqual(cookie.parse('foo=; bar='),{foo:'',bar:''})`
`28`	`28`	`})`
`29`	`29`
	`30`	`+it('should parse cookie with minimum length',function(){`
	`31`	`+assert.deepEqual(cookie.parse('f='),{f:''})`
	`32`	`+})`
	`33`	`+`
`30`	`34`	`it('should URL-decode values',function(){`
`31`	`35`	`assert.deepEqual(cookie.parse('foo="bar=123456789&name=Magic+Mouse"'),`
`32`	`36`	`{foo:'bar=123456789&name=Magic+Mouse'})`

Comments

(0)