- Notifications
You must be signed in to change notification settings - Fork549
Fix bulk query regex issue with parentheses in SELECT and WHERE clauses#1735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge3 commits intomainChoose a base branch fromcopilot/fix-671
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+57 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: cristiand391 <6853656+cristiand391@users.noreply.github.com>
Co-authored-by: cristiand391 <6853656+cristiand391@users.noreply.github.com>
CopilotAI changed the title[WIP] conn.bulk.query- "No sobject type found in query" when parentheses are used in both SELECT and WHERE clausesFix bulk query regex issue with parentheses in SELECT and WHERE clausesJul 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The
conn.bulk.query()method was failing with error "No sobject type found in query" when queries contained parentheses in both SELECT and WHERE clauses. This was caused by a greedy regex that removed too much content from the query string.Problem
The original regex
/\([\s\S]+\)/gwas designed to remove parenthesized content (like subqueries) to extract the main sobject type from the FROM clause. However, it used a greedy quantifier that matched from thefirst opening parenthesis to thelast closing parenthesis, which could remove the entire FROM clause in queries like:The regex would remove everything from
(SELECT Id FROM SubObject1)throughOR c = 3), leaving onlySELECT x, y,and causing the FROM clause extraction to fail.Solution
Replaced the single greedy regex with an iterative approach that removes parenthesized content level by level:
This approach correctly handles:
Testing
Added comprehensive test cases covering:
All existing functionality remains unchanged, and the fix is minimal with only 8 lines of code modified.
Fixes#671.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.iohttps://storage.googleapis.com/chrome-for-testing-public/127.0.6533.72/linux64/chrome-headless-shell-linux64.zipnode install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Clickhere to start the survey.