- Notifications
You must be signed in to change notification settings - Fork470
Improvement: Remember labelling mode#507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
MuhsinFatih wants to merge4 commits intojsbroks:masterChoose a base branch fromMuhsinFatih:master
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Modetool in the toolbar inAnnotatorallows users to switch betweensegmentandlabelmodes, however the user has to click this every time they navigate to the next image if they want to annotate images only with image-level labels. I made a small modification, passing the currentmodeto the route and passing that toAnnotatorprops.The new behavior is that the annotator "remembers" the annotation mode. This makes sense because it is unlikely that a user would want to label images in a dataset to have mixed label types. This will save a lot of time for people who want to only annotate with image-level labels only. In my use-case, clicking the tool every time was a dealbreaker
The change is really very simple. I attached a video showing the new behavior. Notice that it doesn't switch back to
segmentmode when I navigate to the next/previous imageScreen.Recording.2021-09-14.at.10.33.39.PM.mov
Disclaimer:
I never used vue.js for any project (mostly I'm a react and svelte person), so my understanding is very limited. If I used a bad practice please edit my PR to conform with the project guidelines