- Notifications
You must be signed in to change notification settings - Fork15
catch up with Scala 2.11.2 version (the most recent scala virtualized version)#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bump scala version to 2.11.2, remove MacroParadise and other older plugins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why was this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
because Manifest.erasure has been deprecated by .runtimeClass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was talking about the change ofscala.Object forAnyRef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oh, that one. BecauseScalaObject has been removed, and the closest thing to it is AnyRef.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To my understanding, the code
valparents= traitClazz.getInterfaces.filter(_!= implicitly[Manifest[ScalaObject]].runtimeClass)
is to filter out the uninterestingScalaObject root interface that is definitely inherited by all classes we are interested in. SinceScalaObject has beenremoved from the language, it seems that we no longer need this filter. Or do you think we still want to filter outAnyRef as an uninteresting root interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Dothis test still pass with your change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, it still passes.
> testOnly *TestProxy[info] TestProxy:[info] - testProxy[info] Run completed in 682 milliseconds.[info] Total number of tests run: 1[info] Suites: completed 1, aborted 0[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0[info] All tests passed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great, so I merge your PR. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you're welcome! Thanks again for such a great project!
julienrf commentedJun 29, 2015
Hi, Thanks for this! I just left one comment. Can you address it, please? BTW, just out of curiousity, in which context are you using js-scala? |
timxzl commentedJun 29, 2015
Hi@julienrf , Thank you for the prompt reply! I have added a line comment in reply to yours. We are starting a project which generates both C++ and Javascript code, and we would like to try out js-scala as the code generator for Javascript. Seems like js-scala is a very neat tool that fits our need. Thanks a lot for the great work! |
catch up with Scala 2.11.2 version (the most recent scala virtualized version)
bump scala version to 2.11.2
remove MacroParadise and change older plugins like continuations to their most recent alternatives.
catch up with Scala 2.11.2 style, fixing errors and reducing warnings