Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support ofjs-data-sql adapter#328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jmdobry merged 2 commits intojs-data:masterfromLoicMahieu:feature/js-data-sql
Apr 15, 2015

Conversation

LoicMahieu
Copy link
Contributor

js-data-sql works really great browser-side. I use it for manipulate a WebSql database and it works like a charm !
js-data is pretty amazing!

@LoicMahieu
Copy link
ContributorAuthor

In browserify context, if:

require('js-data')window.DSHttpAdapter = require('js-data-http')window.DSSqlAdapter = require('js-data-sql')require('js-data-angular')

There is a bug in adapter registration:

null "new data store created" Defaults {…} null nullnull "registerAdapter" "http" DSHttpAdapter {defaults: Defaults} Object {}null "default adapter is http" null null nullnull "registerAdapter" "sql" DSHttpAdapter {defaults: Defaults} Object {}null "default adapter is http" null null nullnull "registerAdapter" "http" DSHttpAdapter {defaults: Defaults} Object {default: true}null "default adapter is http" null null null

In adapter registration loop (https://github.com/js-data/js-data-angular/blob/master/src/index.js#L205-L214), if the first adapter is well registrated, it continue to loop over next adapter when with a wrong object.
Adding a break fix the issue. (in846c4c0)

(I added a commit to current PR, if separate PR is preferable, just tell me)

@jmdobry
Copy link
Member

Wow, I didn't even realize js-sql-adapter would be useful in the browser. And thanks for the fix!

jmdobry added a commit that referenced this pull requestApr 15, 2015
@jmdobryjmdobry merged commit8a678e6 intojs-data:masterApr 15, 2015
@LoicMahieu
Copy link
ContributorAuthor

@jmdobry Yeah. I thought I was crazy to dig into it but it works!
Seems to fail in CircleCI tests. Bower issue... Perhaps resolution ?https://circleci.com/gh/js-data/js-data-angular/44
CircleCI does not test PR ?

jmdobry added a commit that referenced this pull requestApr 15, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@LoicMahieu@jmdobry

[8]ページ先頭

©2009-2025 Movatter.jp