Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Verify nine-digit zip codes.#726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

johana-star
Copy link
Contributor

No description provided.

@johana-star
Copy link
ContributorAuthor

There was a typo in the regex and nine-digit zip codes (90210-4567) weren't being properly matched.

@jzaefferer
Copy link
Collaborator

Thanks. I added that number to the unit tests, though I didn't actually fail without your modifcation. Still, the fix makes sense.

@goodeye
Copy link

The error was extra digits in front, e.g., 123456-7890, matching 23456-7890 instead of failing. Extra digits now fail, which is good.

@johana-star
Copy link
ContributorAuthor

Something like that:http://rubular.com/r/qDE6GNsXb4

@jzaefferer
Copy link
Collaborator

Thanks, I extended the unit test for that:b51e86f

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johana-star@jzaefferer@goodeye

[8]ページ先頭

©2009-2025 Movatter.jp