Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Verify nine-digit zip codes.#726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a typo in the regex and nine-digit zip codes (90210-4567) weren't being properly matched. |
Thanks. I added that number to the unit tests, though I didn't actually fail without your modifcation. Still, the fix makes sense. |
goodeye commentedMay 18, 2013
The error was extra digits in front, e.g., 123456-7890, matching 23456-7890 instead of failing. Extra digits now fail, which is good. |
Something like that:http://rubular.com/r/qDE6GNsXb4 |
Thanks, I extended the unit test for that:b51e86f |
No description provided.