Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Core: Add support for Web Components#2493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This looks OK to me.
Why? The way you've done it would be my preference over several settings. |
I was thinking because customElements are now listening to both event types: "focusin.validate focusout.validate keyup.validate" but also to "click.validate" instead of just either one of them. The only reliable way to "split" imo would be to make it configurable by the user (therefore the single vs multiple config entries dilemma). |
75f5123
intojquery-validation:masterUh oh!
There was an error while loading.Please reload this page.
Checklist for this pull request
Description
This PR tries to add validation support for custom elements (Web Components). See#2492 for a first technical analysis.
It's possible that the current implementation is not good enough. Especially the part where I added the customElements to both, the "focusin.validate focusout.validate keyup.validate" events and to the "click.validate" events. Maybe we would need to try to differ there or we should go with "more settings value" mentioned in#2492 approach?