Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Core: Add support for Web Components#2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bytestream merged 1 commit intojquery-validation:masterfromdhobi:master
Jun 28, 2024

Conversation

dhobi
Copy link
Contributor

Checklist for this pull request

Description

This PR tries to add validation support for custom elements (Web Components). See#2492 for a first technical analysis.

It's possible that the current implementation is not good enough. Especially the part where I added the customElements to both, the "focusin.validate focusout.validate keyup.validate" events and to the "click.validate" events. Maybe we would need to try to differ there or we should go with "more settings value" mentioned in#2492 approach?

totpero reacted with thumbs up emoji
@bytestream
Copy link
Member

This looks OK to me.

It's possible that the current implementation is not good enough.

Why? The way you've done it would be my preference over several settings.

@bytestreambytestream linked an issueJun 28, 2024 that may beclosed by this pull request
@bytestreambytestream changed the titleCore: Added support for Web Components. Fixes #2492Core: Add support for Web ComponentsJun 28, 2024
@dhobi
Copy link
ContributorAuthor

Why? The way you've done it would be my preference over several settings.

I was thinking because customElements are now listening to both event types: "focusin.validate focusout.validate keyup.validate" but also to "click.validate" instead of just either one of them. The only reliable way to "split" imo would be to make it configurable by the user (therefore the single vs multiple config entries dilemma).
If we just say that web components will always listen for all events, that would be fine for me as well. It's just a decision in the end 😄

@bytestreambytestream merged commit75f5123 intojquery-validation:masterJun 28, 2024
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bytestreambytestreambytestream approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate Web Components
2 participants
@dhobi@bytestream

[8]ページ先頭

©2009-2025 Movatter.jp