Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Localization: Rename message_hi.js to messages_hindi.js#2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Localization: Rename message_hi.js to messages_hindi.js#2470
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This makes it consistent with other i18n file names(which are all written in plural).
I think we'll have to hold off on that as it may break build systems that rely on the old file name. |
EricDunsworth commentedAug 24, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@bytestream Not sure if this makes much of a difference, but FWIW no official releases currently use the file this PR is seeking to rename. Thelatest release of the jQuery validation plugin (1.9.5) was rolled out in July 2022 and doesn't include any Hindi translations at all. The In any case, feel free to close this PR if you still think keeping it "as-is" would be a better bet :). |
Thanks for the clarification@EricDunsworth |
This makes it consistent with other i18n file names (which are all written in plural).