Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Replaced deprecated jQuery functions#2335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ba82525 to38882c7Compare38882c7 to272bb4fCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Lgtm - thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Overall, it looks good to me. I left a comment about the isArray method that I would like to discuss
Uh oh!
There was an error while loading.Please reload this page.
Replaced $.isArray and $.isFunction
272bb4f to360de29CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Thanks a lot for your contribution :)
Description
Replaces functions deprecated in jQuery 3 as perhttps://api.jquery.com/category/deprecated/