Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

set jQuery as a peer dependency#2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Arkni merged 1 commit intojquery-validation:masterfromaigdonia:master
Jan 26, 2019

Conversation

aigdonia
Copy link
Contributor

@aigdoniaaigdonia commentedDec 16, 2018
edited
Loading

After bundle withwebpack this package includes its own jquery to the bundle and no way to get rid of it except by add jquery as apeerDependency to thepackage.json

I found a non merged PR from 2016 here#1858 but setting as adevDependency is not the best fit, so I created this PR

thanks

@staabm
Copy link
Member

staabm commentedDec 16, 2018
edited
Loading

Thx for the PR.

I had to lookup what peerDependencies are.
I came up withhttps://nodejs.org/en/blog/npm/peer-dependencies/

It reads like this is usefull for our library use-case.

@Arkni what do you think?

aigdonia reacted with thumbs up emoji

@Arkni
Copy link
Member

I'm +1 to this change. But, is it ok to release this in a minor/patch version instead of a major one?

aigdonia reacted with hooray emoji

@aigdonia
Copy link
ContributorAuthor

any update to decision here?

@Arkni
Copy link
Member

Hi@aigdonia,

Sorry for taking so long to respond, the last month (and still have limited time) was crazy for me. As I said before, I'm +1 to the idea of removing jQuery from the dependencies and moving it to peer dependencies. The only thing I lack information on is should we release this as part of a patch/minor version or a major one?

If you have any information/recommendation about that, please feel free to provide them.

Thanks a lot for working on this and thanks for your patience :)

@aigdonia
Copy link
ContributorAuthor

as per the definition ofsemver.org
a MAJOR release should make incompatible API changes, which is not the case here,
this change won't affect the current installs of the package as well,
the only effect I see it when newnpm install is introduced withoutjquery being introduced already in the project, there will be a warning to install it.

so I suggest this to be a minor/patch release.

@Arkni
Copy link
Member

Arkni commentedJan 26, 2019
edited
Loading

A minor release it is then.

Thanks@aigdonia for the information :) I'm going to merge this proposal in a moment.

Thanks :)

@ArkniArkni merged commit01ca879 intojquery-validation:masterJan 26, 2019
@staabm
Copy link
Member

Thank you guys 😎

Arkni and aigdonia reacted with hooray emoji

@aigdonia
Copy link
ContributorAuthor

Thanks for the merge

@ericfowler303
Copy link

Would it be possible to publish a beta build or public build of this to bring in via npm? I'm currently having issues with this using webpack due since this commit isn't in a built package.

@tommyip
Copy link

Until a new build is published, simply add the following topackage.json to fix the problem:

"resolutions": {    "jquery-validation/jquery": "3.4"}

(Thanks@marcwieland95 for coming up with the fix in#2272)

marcwieland95 reacted with thumbs up emoji

@pam81
Copy link

I tried this solution but it's still using the jquery from the inside node_module folder.
The only way i found a solution is to removed this folder after doing yarn install.

@staabm
Copy link
Member

I just published jquery-validateion 1.19.1 to npm.

most important change is that jquery is now defined as a peer dependency, so we dont get into your way. see#2248

sorry this took us so long. jq-validation is not top priority atm

skerbis, Arkni, and aigdonia reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@aigdonia@staabm@Arkni@ericfowler303@tommyip@pam81

[8]ページ先頭

©2009-2025 Movatter.jp