Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Core: change focus() to trigger("focus")#2243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Core: change focus() to trigger("focus")#2243
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Change focus() to trigger("focus") so that jQuery Migrate 3.x doesn't flag it as deprecated.Thanks for your contribution! I'll take a look at it as soon as possible! |
No problem@Arkni 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM :)
Thanks a lot for your contribution. And sorry for taking so long to review this PR, it was only a one-line change, but I didn't had the time to check the change.
Fix a well-known warning followingjquery-validation/jquery-validation#2243 andhttps://api.jquery.com/focus/
Fix a well-known warning followingjquery-validation/jquery-validation#2243 andhttps://api.jquery.com/focusout/
Description
This PR changes the focus() to trigger("focus"), so that it is not flagged up in non-live environments using the jQuery Migrate 3.x plugin.
#2238