Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Core: Call to resetInternals removed in remote validation callback#2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bytestream merged 4 commits intojquery-validation:masterfromleonardospina:master
Jan 24, 2023

Conversation

leonardospina
Copy link
Contributor

Hi,

The modification is related to the following issues, which although marked as closed don't seem to be properly fixed:
#12
#1669
#1375

From the user point of view the issue is that fields in a form which has at least one field with remote validation will be "unhighlighted" if the remotely validated field has a valid default value (remote validation is successful and any other invalid field is cleared out);
Validation error messages are still shown on the interface, but the invalid fields are shown as valid (the CSS class is reset)

Thanks,
Leonardo

cars10 and NAlbuquerque reacted with thumbs up emojiJohoseph reacted with hooray emoji
@staabmstaabm requested a review fromArkniNovember 29, 2018 12:49
@Arkni
Copy link
Member

Thanks for your contribution! I'll take a look at it as soon as possible!

@newclaus
Copy link

Is there anybody alive here?

@leonardospina
Copy link
ContributorAuthor

I'd be alive, but I cannot pull it! :-)

@ghost
Copy link

ghost commentedJan 12, 2023•
edited by ghost
Loading

@Arkni@kieran@staabm
Any reason for not merging this PR ?

@bytestream
Copy link
Member

It needs a test, otherwise we just go round in circles :)

@ghost
Copy link

@leonardospina

It needs a test, otherwise we just go round in circles :)

Can you do the test ?

@leonardospina
Copy link
ContributorAuthor

leonardospina commentedJan 17, 2023 via email

Mmmm I should set up a project on purpose, quite hard to find the time (Imoved company 2 years ago, that issue was spotted in a previous companyproject, working with all different technologies now...)*----------------------------------**The worst thing about listening to Iron Maiden for the first time is thatyou cannot listen to Iron Maiden for the first time ever again.*
…
On Tue, 17 Jan 2023 at 09:54, julien-tschappat ***@***.***> wrote:@leonardospina <https://github.com/leonardospina> It needs a test, otherwise we just go round in circles :) Can you do the test ? — Reply to this email directly, view it on GitHub <#2242 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACVVRA7OG6IQ56UEHQFWII3WSZT4DANCNFSM4GHF2KAA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

@ghost
Copy link

@leonardospina
OK, I'll look if I can do something. But can you give me access to your jquery-validation fork repository ? Otherwise I think I will have to do a new PR

@leonardospina
Copy link
ContributorAuthor

@julien-tschappat should be done can you try and access

@ghost
Copy link

@bytestream
I've added the test. Let me know if something else is required.

FYI :@leonardospina

@bytestreambytestream linked an issueJan 24, 2023 that may beclosed by this pull request
@bytestreambytestream merged commitcfe74a1 intojquery-validation:masterJan 24, 2023
@bytestream
Copy link
Member

Many thanks @julien-tschappat :)

@jansokoly
Copy link

Thank you@leonardospina @julien-tschappat@bytestream.

@leonardospina
Copy link
ContributorAuthor

My pleasure.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bytestreambytestreambytestream approved these changes

@ArkniArkniAwaiting requested review from Arkni

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error messages reset with remote-validation
5 participants
@leonardospina@Arkni@newclaus@bytestream@jansokoly
[8]ページ先頭
©2009-2025 Movatter.jp