Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Core: Fix contenteditable detection's regression introduced in #2142#2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Cool. Can we get this unit tested somehow? |
I think we already have some tests for contenteditable elements. One thing I can suggest in order to avoid regressions regarding IE, is for us to apply for a Saucelabs/BrowserStack open source access to use it for testing the plugin in supported IE versions and also on Safari (if it's allowed in the free plan). |
staabm commentedNov 4, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Oh I see. Not sure it’s worthwhile for IE. In case you are condfident with the patch please go ahead and merge it. Thank you |
It's best to wait for feedback from the reporters. I will provided the build file for them and link to it in#2211. |
PrinceCharles23 commentedNov 5, 2018
judging from the code change this seems to do the trick. since i get the package via npm i have no clue how to test the change directly in our project...? |
see#2211 (comment) on how to get the fixed version |
PrinceCharles23 commentedNov 5, 2018
this just links to the fixed file. npm would overwrite this during next build |
Based on the feedback from the comunity, I am going to merge this. |
Arkni commentedNov 18, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@staabm could you please release this fix in a minor version (as we also have some new validation rules added)? You can find the changelog here:https://gist.github.com/Arkni/fc52dc8e4f5ca1ccc7ea1198b0b659a3#file-jquery-validation-changelog-1-19-0-md Thanks :) |
just published 1.19.0 with a fix for this issue. sorry the any inconvenience this bug has caused for you guys. |
Fixes#2211
Fixes#2214
Fixes#2217
Fixes#2225
Fixes#2233