Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Core: Fix contenteditable detection's regression introduced in #2142#2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Arkni
Copy link
Member

Fixes#2211
Fixes#2214
Fixes#2217
Fixes#2225
Fixes#2233

ngocdaothanh reacted with thumbs up emoji
@staabm
Copy link
Member

Cool. Can we get this unit tested somehow?

@Arkni
Copy link
MemberAuthor

I think we already have some tests for contenteditable elements. One thing I can suggest in order to avoid regressions regarding IE, is for us to apply for a Saucelabs/BrowserStack open source access to use it for testing the plugin in supported IE versions and also on Safari (if it's allowed in the free plan).

@staabm
Copy link
Member

staabm commentedNov 4, 2018
edited
Loading

Oh I see. Not sure it’s worthwhile for IE.

In case you are condfident with the patch please go ahead and merge it.
If not we can wait for som of the reporters to confirm the fix.

Thank you

@Arkni
Copy link
MemberAuthor

It's best to wait for feedback from the reporters. I will provided the build file for them and link to it in#2211.

@PrinceCharles23
Copy link

judging from the code change this seems to do the trick. since i get the package via npm i have no clue how to test the change directly in our project...?

@staabm
Copy link
Member

see#2211 (comment) on how to get the fixed version

@PrinceCharles23
Copy link

see#2211 (comment) on how to get the fixed version

this just links to the fixed file. npm would overwrite this during next build

@Arkni
Copy link
MemberAuthor

Based on the feedback from the comunity, I am going to merge this.

@ArkniArkni merged commitdd187b0 intojquery-validation:masterNov 18, 2018
@ArkniArkni deleted the contenteditable-regression branchNovember 18, 2018 11:49
@Arkni
Copy link
MemberAuthor

Arkni commentedNov 18, 2018
edited
Loading

@staabm could you please release this fix in a minor version (as we also have some new validation rules added)?

You can find the changelog here:https://gist.github.com/Arkni/fc52dc8e4f5ca1ccc7ea1198b0b659a3#file-jquery-validation-changelog-1-19-0-md

Thanks :)

@staabm
Copy link
Member

just published 1.19.0 with a fix for this issue.

sorry the any inconvenience this bug has caused for you guys.

Arkni reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Arkni@staabm@PrinceCharles23

[8]ページ先頭

©2009-2025 Movatter.jp