Added CNH Validation (Brazilian License Driver)#2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Closed

Conversation

Copy link

Contributor

Thank you!

joaoissamu added3 commits

Create cnhBR.js

bee93e1

A validation of CNH (Brazilian License Driver)

Update messages_pt_BR.js

44fd8bf

Added portuguese message for CNH validation

Change code style

0552bdf

Arkni added the NEEDS REVIEW label

Copy link

Member

Thanks for your contribution! I'll triage and take a look at it as soon as possible!

Arkni added the Additional Methods label

Arkni requested changes

Copy link

Member

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your contribution. Overall, the PR looks good to me. The only things needed are to fix the code style issues (see full report herehttps://travis-ci.org/jquery-validation/jquery-validation/builds/435727273?utm_source=github_status&utm_medium=notification) and to add a test for your new method. The test should be undertest/additional/cnhBr.js and should be also added toindex.html after these two lines:

Lines 18 to 19 in3a7e593