Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
ABARoutingNumber: Add ABA Routing Number Validation#2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for your contribution! I'll triage and take a look at it as soon as possible! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot for your contribution. Overall, the PR looks good to. Only a minor change and we are good to go.
I would like also if you could add the test file totest/index.html after these two lines:
jquery-validation/test/index.html
Lines 18 to 19 in3a7e593
| <scriptsrc="additional/creditcard.js"></script> | |
| <scriptsrc="additional/netmask.js"></script> |
src/additional/ABARoutingNumber.js Outdated
| * systems. A very common use case would be to validate a form for | ||
| * an ACH bill payment. | ||
| */ | ||
| $.validator.addMethod( "ABARoutingNumber", function( value ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you make the first 3 letters lowercase, so it maintain consistence with the other additional methods?
test/additional/ABARoutingNumber.js Outdated
| @@ -0,0 +1,23 @@ | |||
| QUnit.test( "ABARoutingNumber", function( assert ) { | |||
| var method = methodTest( "ABARoutingNumber" ); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This will need also to be changed after updating the name.
The filenames should also use lower letters. |
Good catch@staabm. @coryasilva could you please rename the source and test files to be the same as the method name? After that, we are good to go. Thanks! |
lol, damn windows box. The company finally gave me a macbook, give me a couple more days to migrate my dev environment and I will make sure the file renames stick. |
Okay I just renamed the files in github. I hope that worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍
Thanks a lot for your contribution :)
Uh oh!
There was an error while loading.Please reload this page.
Description
This is used in the United States to process payments, deposits, or transfers using the Automated Clearing House (ACH) or Fedwire systems. A very common use case would be to validate a form for an ACH bill payment.
https://en.wikipedia.org/wiki/ABA_routing_transit_number