Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Nis br method review#2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Nis br method review#2204
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fixes new implementationFixesjquery-validation#2169
File commited wrong
Fixes new implementationFixesjquery-validation#2196
Rewrite with reviews some mistakesFixesjquery-validation#2203
Rewrite with reviews some mistakesFixesjquery-validation#2203
…jquery-validation into nis-br-method-review
Reviewer of new method nisBr, removing extra spaces.Fixesjquery-validation#2203
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM :)
Thanks a lot for your contribution :) I'll proceed with merging in a moment.
@csmendonca, By the way, you don't need to close a PR and create a new one with the new changes everytime a maintainer requested something. You can just do the changes and push your commit and they will be visible on the PR. I recommend watching this ~38 minutes lessons fromKent C. Dodds, they are the best getting started on contributing to Open Source on GitHub:https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github And, thank you again for your contribution :) |
Hi@Arkni, Sorry about that, it's happing because that was my first contribution to Open Source on GitHub. |
Ah ok. I didn't pay attention. Congratulation on your first contribution and Good luck :) |
Hi@Arkni, Thank you :) |
I've changed some reviews like orientation by@Arkni.
I've removed some spaces then I've chanced creation of date the new method nisBr.
Thank you!