Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Component: Support Bootstrap 4#2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

vairamsvsjdo
Copy link

Optional Bootstrap4 support

Fixes#2130

Checklist for this pull request

Existing tests must work

Description

The demo code for bootstrap requires change to Bootstrap 4 with Bootstrap 4 has reached stable.

Thank you!

@staabm
Copy link
Member

Please add a separate demo instead of changing the existing one

@gwhenne
Copy link
Contributor

Here are the classes which have to be changed in the sample:

"help-block" becomes"invalid-feedback"
"has-error" becomes"is-invalid"
"has-success" becomes"is-valid"

Other changes are needed to the sample:

  • use the new Bootstrap URL (doh!)
  • formatting of the HTML elements

@Arkni
Copy link
Member

Hi@vairamsvsjdo and@gwhenne,

Could any of you create a new demo with Bootstrap v4 instead of updating the Boostrap v3 one? We don't want to replace that demo as there are still people using Boostrap v3 out there.

Thanks!

@Arkni
Copy link
Member

Hi there,

I'm closing this PR in favor of#2173 which adds a new demo for Bootstrap v4.

Thanks@vairamsvsjdo for your contribution, though.

@ArkniArkni closed thisJun 5, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@vairamsvsjdo@staabm@gwhenne@Arkni

[8]ページ先頭

©2009-2025 Movatter.jp