Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Build: Generate sub-resource integrity hashes of the distribution files#2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
staabm merged 2 commits intojquery-validation:masterfromArkni:sri
May 29, 2018

Conversation

Arkni
Copy link
Member

@ArkniArkni commentedSep 24, 2017
edited
Loading

With this, runninggrunt release will generate3 new files 1 file in thedist folder:

  • sri-core.json: contains the hashes ofjquery-validate.js andjquery-validate.min.js
  • sri-additional.json: contains the hashes ofadditional-methods.js andadditional-methods.min.js
  • sri-localization.json: contains the hashes of all JS files insidelocalization folder
  • jquery-validation-sri.json: contains the hashes of all JS files insidedist folder

I can add those files to the list ofdistribution files in case we want to commit them to GitHub.

//c@staabm@vanillajonathan

@staabm
Copy link
Member

Looks cool. Did we discuss using a single sri file vs the 3 you added?
Need to test it locally before merge.

@staabmstaabm self-requested a reviewSeptember 24, 2017 22:16
@Arkni
Copy link
MemberAuthor

No, we didn't. I just felt the need for separating and categorizing the hashes by component.

@staabm
Copy link
Member

staabm commentedSep 25, 2017
edited
Loading

I guess it would be easier for tool driven consumption when all hashes are contained in a single file.
(if this is too much work, we can just merge as is)

@Arkni
Copy link
MemberAuthor

Make sense. I will update it this evening.

@Arkni
Copy link
MemberAuthor

@staabm
Updated per suggestion!

staabm reacted with heart emoji

@Arkni
Copy link
MemberAuthor

Hi@staabm

any comment on this PR?
Should I add those files to the list ofdistribution files in case we want to commit them to GitHub?

@staabm
Copy link
Member

staabm commentedFeb 14, 2018
edited
Loading

I love this change.

Should I add those files to the list of distribution files

I guess we should.

we want to commit them to GitHub?

we dont have this dist folder in our codebase on github.. I dont get what you mean here?

@vanillajonathan
Copy link
Contributor

I would like to see the hash on the website, next to the download link.

@Arkni
Copy link
MemberAuthor

we dont have this dist folder in our codebase on github.. I dont get what you mean here?

We publish thedist folder with every tagged release. For example, seehttps://github.com/jquery-validation/jquery-validation/tree/1.17.0
So, if someone navigates the tags, they will see thedist folder with its content (additional-methods.js,additional-methods.min.js,jquery.validate.js,jquery.validate.min.js). And I would like to add the sri file to be added to this list too.

I would like to see the hash on the website, next to the download link.

We can provide a link to the file in our docs. The file will be hosted here on GitHub, so everyone can access it without going to the website.

@staabm
Copy link
Member

ok cool. please go for it then.

@Arkni
Copy link
MemberAuthor

@staabm

Updated the proposal to include the sri hashes file in tagged releases.

@ArkniArkni added the Build labelMar 4, 2018
@Arkni
Copy link
MemberAuthor

Hi@staabm,

Can we merge this PR? Does it need any other changes I need to do?

@staabmstaabm merged commita3925cd intojquery-validation:masterMay 29, 2018
@ArkniArkni deleted the sri branchMay 29, 2018 09:42
@staabm
Copy link
Member

Looks great, thanks

Arkni reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@staabmstaabmstaabm approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Arkni@staabm@vanillajonathan

[8]ページ先頭

©2009-2025 Movatter.jp