Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Build: Include minified version of additional methods in npm package#2057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Should we also add the jquery-validation/build/release.js Lines 39 to 44 in5482dfd
|
Since nobody requested localizations in the npm package I would leave them out for now. Whats your opinion? |
Arkni commentedSep 3, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The localization folder is already distributed as part of the npm package, see jquery-validation/package.json Lines 30 to 31 in5482dfd
I'm talking about the dist folder committed to GitHub as part of the released tag. Seethe dist folder of the release |
oh I see. please add it then. |
build/release.js Outdated
| @@ -37,6 +37,7 @@ Release.define({ | |||
| generateArtifacts: function( done ) { | |||
| Release.exec( "grunt release", "Grunt command failed" ); | |||
| done([ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sorry for beeing late to the party:
please add a note likekeeps this is of files in sync with package.json "files"-key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done!
thx! |
No description provided.