Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
isHexColor.js#1973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
isHexColor.js#1973
Uh oh!
There was an error while loading.Please reload this page.
Conversation
In this additional file we check is input value is hex formate color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm really sorry for taking so long to review your PR. We were overwhelmed with the increasing number of issues and PR.
I have left some comments I would like addressed before merging.
Also, do you think you can add some tests for this method?
If so, you can create a file undertest/additional/ and import it intest/index.html.
Thanks for your contribution :)
| @@ -0,0 +1,3 @@ | |||
| $.validator.addMethod( "ishexcolor", function( value, element ) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you change the name tohexcolor in order to be consistent with other additional methods?
Also, I would like the file to be renamed tohexcolor as well.
| @@ -0,0 +1,3 @@ | |||
| $.validator.addMethod( "ishexcolor", function( value, element ) { | |||
| return this.optional( element ) || /^#(?:[0-9a-f]{6}|[0-9a-f]{3})$/i.test( value ); | |||
| }, "This is not hex format color" ); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please change this message to something like:Please specify a valid hex color value
In this additional file we check is input value is hex formate color