Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Move jquery dependencies to dev dependencies#1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
staabm commentedSep 9, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Jquery is not a dev but a runtime dependency for jquery-validate. Therefore I think this change is not correct. How did you declare your other jquery dependency? |
inomdzhon commentedSep 9, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@staabm I installed them from As I now understand that my changed useless. Where from |
the version which is available via npm is managed in this repo. |
d621aab
to3861ce2
Compare@svarnoi420 What's the jquery version you're using in your package.json? I have this problem too, and I think it's because I use the latest jquery version (v3) but jquery.validation has a dependency on jquery ^1.7 || ^2.0. So webpack build jquery.validation with jquery v2 and all other libs with jquery v3. |
@Guymestef Yeah, I use jquery v3 too. Hm, I didn't think about this can be reason. I'll try install jquery v2 for analyze. |
I just landed a PR which added support for jquery3.x, will close therefore. feel free to provide further information in case this was not resolved by this change. |
Uh oh!
There was an error while loading.Please reload this page.
I installed jquery-validation from
npm
. After compiled withwebpack
I have two version jquery on my bundle, first - mine, second - it is the plugin jquery dependencies. And so I moved this dependencies to dev dependencies.Weird, why this package have own
node_modules
on folder after installed withnpm