Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Move jquery dependencies to dev dependencies#1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

inomdzhon
Copy link

@inomdzhoninomdzhon commentedSep 8, 2016
edited
Loading

I installed jquery-validation fromnpm. After compiled withwebpack I have two version jquery on my bundle, first - mine, second - it is the plugin jquery dependencies. And so I moved this dependencies to dev dependencies.

Weird, why this package have ownnode_modules on folder after installed withnpm

@staabm
Copy link
Member

staabm commentedSep 9, 2016
edited
Loading

Jquery is not a dev but a runtime dependency for jquery-validate. Therefore I think this change is not correct.

How did you declare your other jquery dependency?

@inomdzhon
Copy link
Author

inomdzhon commentedSep 9, 2016
edited
Loading

@staabm I installed them fromnpm and set aliases$,jquery,jQuery for requiring like thisrequire('jquery') and etc.

Asjquery-validation have own node_modules folder, it defining jquery from there.

I now understand that my changed useless. Where fromnpm gettingjquery-validation? On this repo have another structure andpackage.json thannpm installed.

@staabm
Copy link
Member

the version which is available via npm is managed in this repo.

@staabmstaabmforce-pushed themaster branch 2 times, most recently fromd621aab to3861ce2CompareSeptember 26, 2016 14:28
@Guymestef
Copy link
Contributor

@svarnoi420 What's the jquery version you're using in your package.json?

I have this problem too, and I think it's because I use the latest jquery version (v3) but jquery.validation has a dependency on jquery ^1.7 || ^2.0. So webpack build jquery.validation with jquery v2 and all other libs with jquery v3.

@inomdzhon
Copy link
Author

@Guymestef Yeah, I use jquery v3 too. Hm, I didn't think about this can be reason. I'll try install jquery v2 for analyze.

@staabm
Copy link
Member

I just landed a PR which added support for jquery3.x, will close therefore. feel free to provide further information in case this was not resolved by this change.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@inomdzhon@staabm@Guymestef

[8]ページ先頭

©2009-2025 Movatter.jp